[vcpkg baseline][ms-quic] Passing remove from fail list #39475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangLL
added
info:internal
JonLiu1993
previously approved these changes
Jun 24, 2024
added 2 commits
June 24, 2024 02:15
LilyWangLL
added
the
category:port-bug
added 2 commits
June 24, 2024 03:10
BillyONeal
changed the title
BillyONeal
reviewed
Jun 24, 2024
|
|
||
| # Configure PGO linker flags. | ||
| - if(QUIC_PGO) | ||
| + if(1) |
There was a problem hiding this comment.
This part seems wrong: vcpkg certainly doesn't configure PDGs
There was a problem hiding this comment.
I modify this want to fix the error: LINK : fatal error LNK1268: inconsistent option 'NODEFAULTLIB:libucrt.lib' specified with /USEPROFILE but not with /GENPROFILE.
I saw you fix this by file(REMOVE "${QUIC_SOURCE_PATH}/src/bin/winuser/pgo_x86/msquic.pgd"), thanks.
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jun 24, 2024
Also fix uwp builds so that all ci.baseline.txt entries can be removed, submitted upstream as microsoft/msquic#4373 Originally started from microsoft#39475 Co-authored by: Lily Wang <v-lilywang@microsoft.com>
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Jun 24, 2024
Also fix uwp builds so that all ci.baseline.txt entries can be removed, submitted upstream as microsoft/msquic#4373 Originally started from microsoft#39475 Co-authored by: Lily Wang <v-lilywang@microsoft.com>
BillyONeal
added a commit
to BillyONeal/msquic
that referenced
this pull request
Jun 24, 2024
This is going to be a processor type like x86, x64, arm, or arm64. This change was originally authored by @LilyWangLL in microsoft/vcpkg#39475
|
Closed as duplicate of #39498. |
BillyONeal
added a commit
that referenced
this pull request
Jun 25, 2024
Also fix uwp builds so that all ci.baseline.txt entries can be removed, submitted upstream as microsoft/msquic#4373 Also fix x86-windows builds which incorrectly compared SYSTEM_PROCESSOR with 'win32' rather than 'x86'. Submitted upstream as microsoft/msquic#4374 . This patch originally authored by @LillyWangLL Originally started from #39475 Co-authored by: Lily Wang <v-lilywang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing on https://dev.azure.com/vcpkg/public/_build/results?buildId=104229&view=results.
Fixed by PR #39332.
Also fix the build error of
ms-quic:x86-windows.SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.