Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg-ci-curl] Add c-ares feature to curl test port #40089

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[vcpkg-ci-curl] Add c-ares feature to curl test port #40089

merged 1 commit into from
Jul 26, 2024

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Jul 25, 2024 •
edited by Cheney-W
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@talregev talregev changed the title [vcpkg-ci-curl] Add cares feature to curl test port [vcpkg-ci-curl] Add c-ares feature to curl test port Jul 25, 2024
@talregev talregev marked this pull request as draft July 25, 2024 23:18
@Cheney-W Cheney-W added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Jul 26, 2024
@talregev talregev marked this pull request as ready for review July 26, 2024 03:32
@talregev
Copy link
Contributor Author

@Cheney-W Thank you for the review. Can you add the review label?

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jul 26, 2024
@data-queue data-queue merged commit e948029 into microsoft:master Jul 26, 2024
16 checks passed
@talregev talregev deleted the TalR/curl_test_cares branch July 27, 2024 04:29
@talregev talregev mentioned this pull request Jul 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@data-queue data-queue data-queue approved these changes

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talregev @Cheney-W @data-queue