Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rmqcpp] Update to latest revision #40101

Merged
merged 8 commits into from
Sep 8, 2024
21 changes: 4 additions & 17 deletions ports/rmqcpp/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,12 @@
"dependencies": [
{
"name": "bde",
"host": true,
"version>=": "3.123.0.0"
},
{
"name": "boost-asio",
"host": true
},
{
"name": "boost-iostreams",
"host": true
},
{
"name": "gtest",
"host": true
},
{
"name": "openssl",
"host": true
},
"boost-asio",
"boost-iostreams",
"gtest",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite only being needed for tests, gtest is set as a non-host dependency since there is no way to disable tests in the port for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test dirs are removed from the build. What is left?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try building the port without this dependency? the patch above that deletes add_subdirectory(tests) from CMakeLists.txt should make it so that this dependency is no longer needed.

"openssl",
{
"name": "vcpkg-cmake",
"host": true
Expand Down
Loading