-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rmqcpp] Update to latest revision #40101
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
50a5175
[rmqcpp] Update to latest revision — Fixes #38736
SirWrexes dc8a58d
[rmqcpp] Update version metadata to add 1.0.0#1
SirWrexes 2565863
[rmqcpp] Remove `host: true` on dependencie where it doesn't make sense
SirWrexes a80fce0
[rmqcpp] Update baseline `git-tree`
SirWrexes 36e9884
[rmqcpp] Add patch to skip building examples and tests
SirWrexes 5293891
[rmqcpp] Update baseline and versions file
SirWrexes 46315b4
revert and add port-verison
FrankXie05 6a6a0be
update version
FrankXie05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite only being needed for tests,
gtest
is set as a non-host dependency since there is no way to disable tests in the port for now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test dirs are removed from the build. What is left?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try building the port without this dependency? the patch above that deletes
add_subdirectory(tests)
from CMakeLists.txt should make it so that this dependency is no longer needed.