Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boost] Update to 1.86.0 #40465

Merged
merged 32 commits into from
Oct 18, 2024
Merged

[boost] Update to 1.86.0 #40465

merged 32 commits into from
Oct 18, 2024

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Aug 15, 2024 •
edited
Loading

Fixes #40558.

Questions:

  • Does boost-cobalt need platform expression for boost-context? Also for boost-coroutine (boost-coroutine2 does not have one).
  • How to filter pfr from mysql more cleanly in generate-ports.ps1?
  • boost-exception: header-only in cmake but static in b2

@JonLiu1993 JonLiu1993 self-assigned this Aug 15, 2024
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 15, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Aug 15, 2024

As a drive-by fix: There are some homepage links reported to be broken at https://repology.org/repository/vcpkg/problems.

@dg0yt dg0yt mentioned this pull request Aug 21, 2024
Closed
@Osyotr
Copy link
Contributor Author

Osyotr commented Sep 3, 2024 •
edited
Loading

Currently blocked by compilation errors in the following ports:
ctbench
hazelcast-cpp-client
restc-cpp

@yurybura
Copy link
Contributor

@Osyotr Is there any progress on this PR?

This was referenced Sep 22, 2024
Open
Closed
Closed
@Osyotr
Copy link
Contributor Author

Osyotr commented Sep 22, 2024

@Osyotr Is there any progress on this PR?

The "Boost" part of this PR is done. Waiting for upstreams to respond.

@Osyotr Osyotr marked this pull request as ready for review September 22, 2024 19:16
@yurybura

This comment was marked as outdated.

Sign in to view
@Osyotr

This comment was marked as resolved.

Sign in to view
@yurybura
Copy link
Contributor

boost-build is not used anymore. This port should be removed.

This port contains the b2 executable. How do we know it isn't used by users?

I think better to implement a new port for a tool ports/vcpkg-tool-b2 and scripts like scripts/cmake/vcpkg_find_acquire_program(B2).cmake and scripts/cmake/vcpkg_build_b2.cmake.

@dg0yt dg0yt mentioned this pull request Sep 29, 2024
Closed
@yurybura
Copy link
Contributor

yurybura commented Oct 6, 2024

@Osyotr Could you please tell how soon we can expect completion of this PR? Thank you in advance.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 7, 2024

vcpkg team or PR author could trigger re-run of CI.

@IYanakiev34
Copy link

When is this pull request expected to be merged?

JavierMatosD
JavierMatosD previously approved these changes Oct 16, 2024
View reviewed changes
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 16, 2024
JonLiu1993
JonLiu1993 previously approved these changes Oct 17, 2024
View reviewed changes
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 17, 2024
@BillyONeal
Copy link
Member

@Osyotr Can you take a look at Osyotr#183 and Osyotr#184 ?

@BillyONeal BillyONeal removed info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Oct 18, 2024
@Osyotr
Merge pull request #183 from BillyONeal/boost-186-hazelcast
2212ca6 
[hazelcast-cpp-client] Fix build with Boost 1.86.
@Osyotr Osyotr dismissed stale reviews from JonLiu1993 and JavierMatosD via 2212ca6 October 18, 2024 06:51
@BillyONeal BillyONeal merged commit 054637a into microsoft:master Oct 18, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thank you for the update!

@Osyotr Osyotr deleted the boost-update branch October 18, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurybura yurybura yurybura requested changes

@BillyONeal BillyONeal BillyONeal left review comments

@JonLiu1993 JonLiu1993 JonLiu1993 left review comments

@JavierMatosD JavierMatosD JavierMatosD left review comments

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Boost] update to 1.86.0
7 participants
@Osyotr @dg0yt @yurybura @IYanakiev34 @BillyONeal @JavierMatosD @JonLiu1993