Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsoncpp] Fix repeated find_package #40548

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[jsoncpp] Fix repeated find_package #40548

merged 1 commit into from
Aug 22, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Aug 20, 2024

@petersteneteg
Copy link
Contributor

Great! thanks for taking the time to fix this!

@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 20, 2024
@FrankXie05
Copy link
Contributor

Approved to this change because upstream has agreed.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Aug 21, 2024
@vicroms vicroms merged commit 1e00238 into microsoft:master Aug 22, 2024
16 checks passed
@dg0yt dg0yt deleted the jsoncpp branch August 22, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on multiple find_package calls for the same library
4 participants
@dg0yt @petersteneteg @FrankXie05 @vicroms