Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lfreist-hwinfo] Add new port #40706

Merged
merged 10 commits into from
Sep 5, 2024
Merged

[lfreist-hwinfo] Add new port #40706

merged 10 commits into from
Sep 5, 2024

Conversation

Hlongyu
Copy link
Contributor

@Hlongyu Hlongyu commented Aug 29, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@WangWeiLin-MV WangWeiLin-MV changed the title [hwinfo] rename to lfreist-hwinfo [lfreist-hwinfo] Add new port Aug 30, 2024
@WangWeiLin-MV WangWeiLin-MV added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Aug 30, 2024
@WangWeiLin-MV
Copy link
Contributor

Wait for #40708

@Hlongyu Hlongyu mentioned this pull request Aug 30, 2024
Closed
WangWeiLin-MV
WangWeiLin-MV reviewed Sep 2, 2024
View reviewed changes
WangWeiLin-MV
WangWeiLin-MV approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port usage tests pass with the following triplets:

  • x64-linux
  • x64-windows
  • x86-windows-static

@WangWeiLin-MV WangWeiLin-MV removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 2, 2024
@microsoft microsoft deleted a comment from azure-pipelines bot Sep 4, 2024
@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Sep 4, 2024
@vicroms vicroms merged commit 994bab2 into microsoft:master Sep 5, 2024
16 checks passed
@vicroms
Copy link
Member

vicroms commented Sep 5, 2024

Thanks for resubmitting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hlongyu @WangWeiLin-MV @vicroms @FrankXie05 @jimwang118