Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shader-slang] Updating to 2024.10 #40747

Merged
merged 23 commits into from
Sep 5, 2024
Merged

[shader-slang] Updating to 2024.10 #40747

merged 23 commits into from
Sep 5, 2024

Conversation

Honeybunch
Copy link
Contributor

In updating this port I found that slangc when installed as a tool was missing some dependencies so I made sure that they got installed properly. I guess there was no way for vcpkg_copy_tools to detect that slangc / slangd need these other shared libraries to function.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two things needed for vcpkg_copy_tools: The runtime lib must be in the function's search path, and the dependency must be announced to the dynamic linker. Modules/plugins loaded later during runtime cannot be detected.

ports/shader-slang/portfile.cmake Outdated Show resolved Hide resolved
ports/shader-slang/portfile.cmake Show resolved Hide resolved
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 2, 2024
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Sep 2, 2024
@vicroms vicroms merged commit 85a9996 into microsoft:master Sep 5, 2024
16 checks passed
@Honeybunch
Copy link
Contributor Author

ACK! I think I was wrong. No idea how I avoided getting bit by this until now. There is a problem with this.
image
Sorry for the screenshot, over VNC.
Seems that the RPATH of slangc can't be updated by vcpkg and as warned it screws with code-signing. I am not enough of an expert in code-signing to know exactly what's up or if there's a straightforward fix.

If you're struggling with macos failing to use slangc with "Killed 9:" this is why 😢

@Honeybunch
Copy link
Contributor Author

Nevermind, I needed to sleep. I just realized I can turn off rpath modifications for osx and that worked. I should have a patch up soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants