Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fast-double-parser] update to 0.8.0 #40975

Merged
merged 10 commits into from
Sep 21, 2024

Conversation

jiayuehua
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Sep 14, 2024
Cheney-W
Cheney-W previously approved these changes Sep 14, 2024
@Osyotr
Copy link
Contributor

Osyotr commented Sep 14, 2024

The library now installs cmake config, so the port should use vcpkg_cmake_* functions instead of just copying a header file.

@BillyONeal BillyONeal marked this pull request as draft September 16, 2024 19:52
@jiayuehua jiayuehua marked this pull request as ready for review September 19, 2024 11:36

#vcpkg_cmake_config_fixup(PACKAGE_NAME fast_double_parser CONFIG_PATH "lib/cmake/cpp-sort")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still commented out, it seems this is still being worked on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is not needed . I just Have deleted this comment .

@BillyONeal BillyONeal marked this pull request as draft September 19, 2024 20:34
@jiayuehua jiayuehua marked this pull request as ready for review September 20, 2024 02:47
@dg0yt
Copy link
Contributor

dg0yt commented Sep 20, 2024

IMO this should be handled with vcpkg_cmake_config_fixup(PACKAGE_NAME fast_double_parser):

fast-double-parser:x64-linux:/share/fast_double_parser/fast_double_parser-config.cmake
fast-double-parser:x64-linux:/share/fast_double_parser/fast_double_parser-targets.cmake

@Cheney-W
Copy link
Contributor

@jiayuehua
Could you please follow dg0yt's suggestion to add a call to the vcpkg_cmake_config_fixup function in the portfile.cmake file? At the same time, you need to add the vcpkg-cmake-config dependency in the vcpkg.json file.
Although calling this function will not change the current output files or layout of this port, doing so can help prevent potential issues in the future if the upstream modifies the exported contents.

@Osyotr
Copy link
Contributor

Osyotr commented Sep 20, 2024

Although calling this function will not change the current output files or layout of this port

This is because of the spurious set(VCPKG_BUILD_TYPE release) in the portfile.

@jiayuehua
Copy link
Contributor Author

@jiayuehua

Could you please follow dg0yt's suggestion to add a call to the vcpkg_cmake_config_fixup function in the portfile.cmake file? At the same time, you need to add the vcpkg-cmake-config dependency in the vcpkg.json file.

Although calling this function will not change the current output files or layout of this port, doing so can help prevent potential issues in the future if the upstream modifies the exported contents.

ok I will follow dg0yt's advice summit the change later.

@BillyONeal
Copy link
Member

Although calling this function will not change the current output files or layout of this port

This is because of the spurious set(VCPKG_BUILD_TYPE release) in the portfile.

How is it "spurious"? Is the library not header only any longer?

@Osyotr
Copy link
Contributor

Osyotr commented Sep 20, 2024

How is it "spurious"? Is the library not header only any longer?

I was thinking about interface properties in debug config, but now I see that set(VCPKG_BUILD_TYPE release) + vcpkg_cmake_config_fixup is widely used in vcpkg.
https://github.com/search?q=repo%3Amicrosoft%2Fvcpkg+set%28VCPKG_BUILD_TYPE+vcpkg_cmake_config_fixup&type=code

@BillyONeal BillyONeal merged commit 98aa639 into microsoft:master Sep 21, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@jiayuehua jiayuehua deleted the fast-double-parser branch September 21, 2024 04:06
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants