Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wcdb-sqlcipher] add new port wcdb-sqlcipher which maintained by WeChat team #41145

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RightFS
Copy link

@RightFS RightFS commented Sep 24, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

tested on Windows/MacOS/iOS/Android,

I will create a new pr for the WCDB which a multifunctional library based on sqlcipher

@RightFS
Copy link
Author

RightFS commented Sep 24, 2024

@microsoft-github-policy-service agree company="JoyMoe"

1 similar comment
@RightFS
Copy link
Author

RightFS commented Sep 24, 2024

@microsoft-github-policy-service agree company="JoyMoe"

@jimwang118 jimwang118 changed the title add new port wcdb-sqlcipher which maintained by WeChat team [wcdb-sqlcipher] add new port wcdb-sqlcipher which maintained by WeChat team Sep 24, 2024
@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 24, 2024
@jimwang118
Copy link
Contributor

There is already an sqlcipher port in vcpkg. Does this port not meet your needs?

@RightFS
Copy link
Author

RightFS commented Oct 8, 2024

There is already an sqlcipher port in vcpkg. Does this port not meet your needs?

This sqlcipher is a modified version that wcdb depends on.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 8, 2024

Does it use conflicting file names?
Does it provide conflicting symbol names?

@JavierMatosD JavierMatosD marked this pull request as draft October 8, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants