Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openxlsx] Add new port #41150

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ea61266
original cmake file
motazmuhammad Jun 22, 2024
711e46d
Merge branch 'master' of https://github.com/microsoft/vcpkg
motazmuhammad Sep 24, 2024
0472204
version database
motazmuhammad Sep 24, 2024
55563e9
remove unnecessary lines
motazmuhammad Sep 24, 2024
e43fb14
necessary updates
motazmuhammad Sep 24, 2024
dd2833d
add usage file
motazmuhammad Sep 24, 2024
1e24e15
add usage file
motazmuhammad Sep 24, 2024
664e690
Merge branch 'microsoft:master' into OpenXLSX
motazmuhammad Sep 24, 2024
85b17ad
Merge branch 'microsoft:master' into OpenXLSX
motazmuhammad Sep 25, 2024
4340fa5
Revert "original cmake file"
motazmuhammad Sep 26, 2024
c7a19b7
Merge branch 'OpenXLSX' of https://github.com/motazmuhammad/vcpkg int…
motazmuhammad Sep 26, 2024
35c16e7
respond to comments
motazmuhammad Sep 26, 2024
47fee1d
add a version file and update the baseline.json
motazmuhammad Sep 27, 2024
b250091
change to 0.3.2
motazmuhammad Sep 27, 2024
0de260f
add the versions changes and baseline
motazmuhammad Sep 27, 2024
2e33e06
fix missing dependencies
motazmuhammad Sep 29, 2024
5612e8b
Add a batch file and use the version string
motazmuhammad Sep 30, 2024
8cd999c
add the patch file
motazmuhammad Sep 30, 2024
8a3debe
fix the version file
motazmuhammad Sep 30, 2024
ebf9f13
Merge branch 'microsoft:master' into OpenXLSX
motazmuhammad Sep 30, 2024
a0ead3b
reply to comments
motazmuhammad Oct 1, 2024
9fc3458
Merge branch 'OpenXLSX' of https://github.com/motazmuhammad/vcpkg int…
motazmuhammad Oct 1, 2024
5052147
fix the version file
motazmuhammad Oct 1, 2024
e7ebe60
fix the sha-512 and version file
motazmuhammad Oct 1, 2024
fba6097
fix the version file
motazmuhammad Oct 1, 2024
f9d16ac
Update ports/openxlsx/usage
motazmuhammad Oct 2, 2024
57fe05a
Update usage
motazmuhammad Oct 2, 2024
c3f6335
fix version file
motazmuhammad Oct 2, 2024
95143b6
Merge branch 'microsoft:master' into OpenXLSX
motazmuhammad Oct 6, 2024
47e8d65
Update ports/openxlsx/portfile.cmake
motazmuhammad Oct 8, 2024
10da30b
Update ports/openxlsx/portfile.cmake
motazmuhammad Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ports/openxlsx/portfile.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Header-only library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Header-only library
# Header-only library
set(VCPKG_BUILD_TYPE release)

vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO troldal/OpenXLSX
REF master
SHA512 429215a961cfcfe8fcb49ee48970dd10dccad09a5c80db2eea2413120a51a2529c9a650584a079756c3b463d53f1fcdec46fdc158ffbc680592896867f60d3ea
motazmuhammad marked this conversation as resolved.
Show resolved Hide resolved
HEAD_REF master
)
vcpkg_cmake_configure(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PREFER_NINJA

Default.

OPTIONS
-DOPENXLSX_BUILD_TESTS=OFF
motazmuhammad marked this conversation as resolved.
Show resolved Hide resolved
)
vcpkg_cmake_install()
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/OpenXLSX)
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
file(COPY "${SOURCE_PATH}/OpenXLSX/external" DESTINATION "${CURRENT_PACKAGES_DIR}/include")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External? It looks like this is vending zippy, pugixml, and nowide

Pleas see https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-use-vendored-dependencies

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JavierMatosD one of the dependencies (zippy) is not in vcpkg, should it be added to vcpkg, in a separate port as a requirement for this port?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Please open another PR adding zippy as a port as it is a requirement for this port.

file(COPY "${SOURCE_PATH}/OpenXLSX/headers/XLException.hpp" DESTINATION "${CURRENT_PACKAGES_DIR}/include")


vcpkg_copy_pdbs()


# Handle copyright
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE.md")
file(INSTALL "${CMAKE_CURRENT_LIST_DIR}/usage" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}")
3 changes: 3 additions & 0 deletions ports/openxlsx/usage
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
find_package(OpenXLSX CONFIG REQUIRED)
target_link_libraries(main PRIVATE OpenXLSX::OpenXLSX)

motazmuhammad marked this conversation as resolved.
Show resolved Hide resolved
17 changes: 17 additions & 0 deletions ports/openxlsx/vcpkg.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"name": "openxlsx",
"version": "0.3.2",
"description": "OpenXLSX is a C++ library for reading, writing, creating and modifying Microsoft Excel® files, with the .xlsx format.",
"homepage": "https://github.com/troldal/OpenXLSX",
"license": "BSD-3-Clause",
"dependencies": [
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
]
}
4 changes: 4 additions & 0 deletions versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -6732,6 +6732,10 @@
"baseline": "2.5.1",
"port-version": 0
},
"openxlsx": {
"baseline": "0.3.2",
"port-version": 0
},
"openxr-loader": {
"baseline": "1.0.31",
"port-version": 0
Expand Down
9 changes: 9 additions & 0 deletions versions/o-/openxlsx.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"versions": [
{
"git-tree": "fec0b77e7b174435eb3b15c10e973bdb6a6dd604",
"version": "0.3.2",
"port-version": 0
}
]
}
Loading