Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cudnn] Fix cudnn dlls #41153

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

Olli1080
Copy link
Contributor

@Olli1080 Olli1080 commented Sep 24, 2024

This fixes that dlls won't be installed under windows when using TARGET_RUNTIME_DLLS generator expression in cmake.
The cause is a misspelled variable.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 25, 2024
@Olli1080
Copy link
Contributor Author

I've found another edge case.
When copying cudnn into the cuda installation the path for the dlls is located at ../bin relative to the includes.
But when using the installer the include and bin directory are augmented by a folder with a cuda version. (e.g. include/12.6/; bin/12.6/

@JavierMatosD JavierMatosD marked this pull request as draft October 4, 2024 15:51
@Olli1080 Olli1080 marked this pull request as ready for review October 6, 2024 00:32
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Oct 8, 2024
@JavierMatosD
Copy link
Contributor

Tagging this team review on account that we don't allow find modules in the repo. I know this is already the status quo but given that this is the ports 15th revision, these are substantial changes to the find module, and FindCUDA.cmake is deprecated, I'm not exactly sure how to proceed here.

@JavierMatosD JavierMatosD added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. depends:vcpkg-team This PR depends on the vcpkg team to solve something labels Oct 9, 2024
@FrankXie05 FrankXie05 changed the title Fix cudnn dlls [cudnn] Fix cudnn dlls Oct 12, 2024
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:vcpkg-team This PR depends on the vcpkg team to solve something requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants