[sqlpp11] Fix libmariadb linkage, generate usage #41201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangWeiLin-MV
approved these changes
Sep 27, 2024
WangWeiLin-MV
added
category:port-bug
Comment on lines
+35
to
+45
| set(usage "sqlpp11 provides CMake targets:\n") | ||
| if(FEATURES STREQUAL "core") | ||
| set(usage "This build of sqlpp11 doesn't include any connector.\n(Available via features: sqlite3, mariadb, mysql, postgresql.)\n") | ||
| endif() | ||
| foreach(component IN ITEMS SQLite3 SQLCipher MySQL MariaDB PostgreSQL) | ||
| string(TOLOWER "${component}" lib) | ||
| if("${lib}" IN_LIST FEATURES) | ||
| string(APPEND usage "\n find_package(Sqlpp11 CONFIG REQUIRED COMPONENTS ${component})\n target_link_libraries(main PRIVATE sqlpp11::${lib})\n") | ||
| endif() | ||
| endforeach() | ||
| file(WRITE "${CURRENT_PACKAGES_DIR}/share/${PORT}/usage" "${usage}") |
There was a problem hiding this comment.
Why do this as opposed to simply writing a usage file?
There was a problem hiding this comment.
For copy&paste and good UX with minimal output, subject to actual features. Both CMake commands should name the backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.