Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sndfile] Delist sndfile #41203

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[sndfile] Delist sndfile #41203

merged 2 commits into from
Oct 1, 2024

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 26, 2024

Empty port since 2019, forwarding to libsndfile.

@JonLiu1993 JonLiu1993 changed the title Delist sndfile [sndfile] Delist sndfile Sep 27, 2024
@JonLiu1993 JonLiu1993 added the category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. label Sep 27, 2024
@JonLiu1993
Copy link
Member

Doesn't the following code need to be deleted?
versions/baseline.json

    "sndfile": {
      "baseline": "0",
      "port-version": 2
    },

@dg0yt
[pulseaudio] Use libsndfile directly
9abcc10
@dg0yt
Delist sndfile
144b070 
Empty port since 2019, forwarding to libsndfile.
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 29, 2024
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 30, 2024
@JavierMatosD JavierMatosD merged commit d4b7b9b into microsoft:master Oct 1, 2024
16 checks passed
@dg0yt dg0yt deleted the sndfile branch October 2, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dg0yt @JonLiu1993 @BillyONeal @JavierMatosD