Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angle] Fix display selection for macOS and iOS platforms #41239

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented Sep 29, 2024

Fix #40634

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
  1. Added direct inclusion of DisplayApple_api.h for macOS and iOS support.

  2. Updated the display creation logic to utilize rx::CreateDisplayCGLOrEAGL instead of rx::DisplayEGL(Upstream usage).

  3. Kept existing implementations for Windows, Linux, and Android platforms intact.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 29, 2024
@FrankXie05 FrankXie05 marked this pull request as ready for review September 29, 2024 08:22
@FrankXie05
Copy link
Contributor Author

@hsdk123 Could you please test this PR?

@Cheney-W Cheney-W marked this pull request as draft September 30, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[angle] build failure ios
2 participants