Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kfr] Update to 6.0.3 and disable cross-compiling detection #41436

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[kfr] Update to 6.0.3 and disable cross-compiling detection #41436

wants to merge 1 commit into from

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Oct 9, 2024 •
edited
Loading

Related #40503

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port usage tests pass with the following triplets:

  • arm64-macos
  • x64-android
  • x64-linux
  • x64-windows
  • x86-windows (With CMAKE_CROSSCOMPILING)

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Oct 9, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title [kfr] Update to 6.0.3 and disable detect cross-compiling [kfr] Update to 6.0.3 and disable cross-compiling detection Oct 9, 2024
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/kfr/disable-detect-cross-compiling branch from 4692bd3 to 1afc54e Compare October 9, 2024 07:51
dg0yt
dg0yt reviewed Oct 10, 2024
View reviewed changes
ports/kfr/vcpkg.json Outdated Show resolved Hide resolved
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/kfr/disable-detect-cross-compiling branch 3 times, most recently from 6a8d8d3 to 50b82b2 Compare October 10, 2024 06:20
dg0yt
dg0yt reviewed Oct 10, 2024
View reviewed changes
ports/kfr/vcpkg.json Outdated Show resolved Hide resolved
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/kfr/disable-detect-cross-compiling branch 2 times, most recently from bdde581 to fcf620f Compare October 11, 2024 02:23
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review October 12, 2024 02:56
@WangWeiLin-MV WangWeiLin-MV assigned FrankXie05 and unassigned Cheney-W Oct 12, 2024
FrankXie05
FrankXie05 previously approved these changes Oct 12, 2024
View reviewed changes
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Oct 12, 2024
BillyONeal
BillyONeal reviewed Oct 18, 2024
View reviewed changes
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
BillyONeal
BillyONeal reviewed Oct 18, 2024
View reviewed changes
ports/kfr/0100-disable-detect-cross-compiling.patch
endif ()
endif ()

-if (KFR_ARCH IN_LIST DETECT_NAMES AND NOT CMAKE_CROSSCOMPILING)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what this change does? (I'm not saying I think there's anything wrong with it, I'm just not sure how to evaluate its correctness, so I'm trying to understand the problem you're fixing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block will detect target architecture and generate header file for native-compiling. Although it will not fail the compilation, it might introduce additional features depends on compiler instead of determinate features.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. additional features that depend on compiler on exact build machine CPU ?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't look at the source code carefully.

The main intention here is to prevent using different source code when cross-compiling.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main intention here is to prevent using different source code when cross-compiling.

That doesn't appear to be what this code does?

Can we get upstream to comment here? It isn't clear that the resulting port does what its users expect it to do....

@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/kfr/disable-detect-cross-compiling branch from fcf620f to 4731c4f Compare October 18, 2024 06:40
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/kfr/disable-detect-cross-compiling branch from 4731c4f to 1f32b3e Compare October 18, 2024 06:46
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/kfr/disable-detect-cross-compiling branch from 1f32b3e to 791cce4 Compare October 18, 2024 07:04
@data-queue data-queue added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 23, 2024
BillyONeal
BillyONeal reviewed Nov 22, 2024
View reviewed changes
ports/kfr/vcpkg.json
"description": "Fast, modern C++ DSP framework.",
"homepage": "https://www.kfr.dev/",
"license": "GPL-2.0",
"supports": "!(arm | linux | xbox)",
"license": "GPL-2.0-or-later",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anywhere where this says or later, can you point to where you see that?

I think GPL-2.0-only OR GPL-3.0-only would work...

@BillyONeal BillyONeal removed info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Nov 22, 2024
@BillyONeal BillyONeal marked this pull request as draft November 22, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@BillyONeal BillyONeal BillyONeal left review comments

@FrankXie05 FrankXie05 FrankXie05 left review comments

Assignees

@FrankXie05 FrankXie05

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WangWeiLin-MV @BillyONeal @dg0yt @FrankXie05 @Cheney-W @data-queue