Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpr] Update cpr to version 1.11.0 #41877

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Conversation

Deishelon
Copy link
Contributor

Fixes: #41876

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Deishelon
Copy link
Contributor Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

HEAD_REF master
PATCHES
disable_werror.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the patch or effect. vcpkg doesn't control the user's toolchain, so it doesn't want -Werror.

Copy link
Contributor Author

@Deishelon Deishelon Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do, but just FYI, I have not seen port compile fail on Linux (gcc) and Android (Clang). (CI is also happy)

Also, I might have missed this in the docs, but general question, why not to turn off these in every possible port? Why need this in this port and not in others ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not seen port compile fail on Linux (gcc) and Android (Clang). (CI is also happy)

Sure, but it is only small subset of possible environments. In particular, not including tomorrow's compiler releases' new diagnostic warnings.
And this package even uses -Wpedantic, so it is really fragile.

why not to turn off these in every possible port? Why need this in this port and not in others ?

A patch is needed where a package enables -Werror unconditionally. Usually, it is only added when it is noticed, i.e. when it fails for the first user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt patch is restored (updated to match new CMake file from upstream too)

@jimwang118 jimwang118 changed the title Update cpr to version 1.11.0 [cpr]Update cpr to version 1.11.0 Oct 31, 2024
@jimwang118 jimwang118 changed the title [cpr]Update cpr to version 1.11.0 [cpr] Update cpr to version 1.11.0 Oct 31, 2024
@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 31, 2024
@jimwang118
Copy link
Contributor

All features passed with following triplets:

x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Nov 1, 2024
@vicroms vicroms merged commit 1e54a43 into microsoft:master Nov 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cpr] update to 1.11.0
4 participants