-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpr] Update cpr to version 1.11.0 #41877
Conversation
@microsoft-github-policy-service agree |
HEAD_REF master | ||
PATCHES | ||
disable_werror.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restore the patch or effect. vcpkg doesn't control the user's toolchain, so it doesn't want -Werror
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will do, but just FYI, I have not seen port compile fail on Linux (gcc) and Android (Clang). (CI is also happy)
Also, I might have missed this in the docs, but general question, why not to turn off these in every possible port? Why need this in this port and not in others ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not seen port compile fail on Linux (gcc) and Android (Clang). (CI is also happy)
Sure, but it is only small subset of possible environments. In particular, not including tomorrow's compiler releases' new diagnostic warnings.
And this package even uses -Wpedantic
, so it is really fragile.
why not to turn off these in every possible port? Why need this in this port and not in others ?
A patch is needed where a package enables -Werror
unconditionally. Usually, it is only added when it is noticed, i.e. when it fails for the first user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dg0yt patch is restored (updated to match new CMake file from upstream too)
All features passed with following triplets:
|
Fixes: #41876
./vcpkg x-add-version --all
and committing the result.