Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[juce] update Juce to 8.0.4 #42593

Merged
merged 3 commits into from
Dec 9, 2024
Merged

[juce] update Juce to 8.0.4 #42593

merged 3 commits into from
Dec 9, 2024

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Dec 8, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Contributor

dg0yt commented Dec 8, 2024

From arm64-windows config log:

-- Configuring juceaide
-- Building juceaide
-- Exporting juceaide
-- Testing juceaide
CMake Error at extras/Build/juceaide/CMakeLists.txt:191 (message):
  Testing juceaide failed:

This port doesn't have an arm windows problem. This port has a cross-build problem.
Upstream tries to reinvoke CMake to build host tools.
The vcpkg port must make available and use the tools from the host triplet instead.

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 9, 2024
@BillyONeal BillyONeal merged commit 8d0005f into microsoft:master Dec 9, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@aminya
Copy link
Contributor Author

aminya commented Dec 9, 2024

From arm64-windows config log:

-- Configuring juceaide
-- Building juceaide
-- Exporting juceaide
-- Testing juceaide
CMake Error at extras/Build/juceaide/CMakeLists.txt:191 (message):
  Testing juceaide failed:

This port doesn't have an arm windows problem. This port has a cross-build problem. Upstream tries to reinvoke CMake to build host tools. The vcpkg port must make available and use the tools from the host triplet instead.

@dg0yt How do we fix that? juceaide is a tool used during plugin generation, so it should work for a full working Juce.

@aminya
Copy link
Contributor Author

aminya commented Dec 9, 2024

Thanks for the update!

You're welcome!

@BillyONeal
Copy link
Member

Thanks for the update!

I merged this despite the problems enumerated above because it didn't appear to be a regression vs. the status quo.

@dg0yt How do we fix that? juceaide is a tool used during plugin generation, so it should work for a full working Juce.

I think JUCE_BUILD_HELPER_TOOLS should be guarded to only run for the host triplet, and non-host triplets need to get those tools from the host triplet rather than attempting to build them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants