Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openfbx] Update port openfbx to latest version #42610

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

flarive
Copy link
Contributor

@flarive flarive commented Dec 9, 2024

Update vcpkg openfbx to latest

@flarive
Copy link
Contributor Author

flarive commented Dec 9, 2024

@microsoft-github-policy-service agree [company=""]

@flarive
Copy link
Contributor Author

flarive commented Dec 9, 2024

@microsoft-github-policy-service agree

@flarive
Copy link
Contributor Author

flarive commented Dec 9, 2024

What should i do to fix that, really don't know how to fix failure :(

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 10, 2024
@JonLiu1993 JonLiu1993 changed the title Update vcpkg openfbx to latest [openfbx] Update port openfbx to latest version Dec 10, 2024
@JonLiu1993
Copy link
Member

@flarive, Please run command ./vcpkg x-add-version openfbx and commit again.

@JonLiu1993 JonLiu1993 marked this pull request as draft December 10, 2024 02:36
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@flarive
Copy link
Contributor Author

flarive commented Dec 10, 2024

vcpkg x-add-version openfbx done !

@flarive flarive marked this pull request as ready for review December 10, 2024 12:52
@flarive
Copy link
Contributor Author

flarive commented Dec 10, 2024

Hello @JonLiu1993, i think everything is ok for the review and the merge in master :)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 11, 2024
@flarive
Copy link
Contributor Author

flarive commented Dec 11, 2024

Thanks for the review @JonLiu1993, i still have the message "Merging is blocked"
(Merge is not an allowed merge method in this repository. This branch must not contain merge commits.)

How can i merge in master ?

@JonLiu1993
Copy link
Member

Thanks for the review @JonLiu1993, i still have the message "Merging is blocked" (Merge is not an allowed merge method in this repository. This branch must not contain merge commits.)

How can i merge in master ?

  1. git remote add Upstream https://github.com/Microsoft/vcpkg
  2. git pull Upstream master
  3. git push

@flarive
Copy link
Contributor Author

flarive commented Dec 11, 2024

Hey @JonLiu1993 , what am i supposed to do now ?

I did :
git remote add Upstream https://github.com/Microsoft/vcpkg
git pull Upstream master
git push

but don't know the meaning of that, i still can't see openfbx latest in vcpkg catalog :(
https://vcpkg.io/en/packages?query=openfbx

@dg0yt
Copy link
Contributor

dg0yt commented Dec 11, 2024

@flarive Just wait for the repo owners to merge your PR.

@JavierMatosD JavierMatosD merged commit e7283e1 into microsoft:master Dec 12, 2024
17 checks passed
@flarive
Copy link
Contributor Author

flarive commented Dec 13, 2024

@JavierMatosD , I still see openfbx 2022-07-18 on vcpkg website instead of latest just merged, why ?
https://vcpkg.io/en/package/openfbx

@JonLiu1993
Copy link
Member

@JavierMatosD , I still see openfbx 2022-07-18 on vcpkg website instead of latest just merged, why ? https://vcpkg.io/en/package/openfbx

@flarive, https://vcpkg.io/en/package/openfbx this website is manually updated, not in real time.

@flarive
Copy link
Contributor Author

flarive commented Dec 13, 2024

Ok, but when i add "openfbx" to my vcpkg.json and i recompile my solution, i still have the old openfbx being downloaded to vcpkg_installed, what's the problem, i really don't understand why it takes so much time to have the latest version available and ready to use :(

When will it be usable ?

@JonLiu1993
Copy link
Member

Ok, but when i add "openfbx" to my vcpkg.json and i recompile my solution, i still have the old openfbx being downloaded to vcpkg_installed, what's the problem, i really don't understand why it takes so much time to have the latest version available and ready to use :(

When will it be usable ?

Have you use command "git pull" get the latest version of vcpkg?

@flarive
Copy link
Contributor Author

flarive commented Dec 13, 2024

Ah sorry i was not clear may be, i want to use openfbx in a raytracer project i'm working on.

Don't understand why it's so long and so complicated to have up to date packages (ports) on vcpkg :(
One week to have an updated port available is a quite poor user experience to be honest.
Asking developers to contribute to updating ports to latest version is ok (i understand even if Microsoft teams could do the job i suppose), but it would be great to have a much faster and smoother experience to avoid developers worldwide being blocked during one week by the MR/review/deploy painfull process.

So, my question is still quite the same again :
When latest openfbx vcpkg package will be available for download in my raytracer project ?

@dg0yt
Copy link
Contributor

dg0yt commented Dec 13, 2024

When the PR is merged, that version is available. Of course you need to git pull and to update the baseline in your project's manifest.

@flarive
Copy link
Contributor Author

flarive commented Dec 13, 2024

Ok, seems to work now with vcpkg update (not sure) and vcpkg x-update-baseline.
I didn't know i had to do that.
Thanks a lot

@flarive flarive deleted the openfbx_latest branch December 14, 2024 09:19
@flarive flarive restored the openfbx_latest branch December 16, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants