[libsmb2] update to v6.2 and add features to activate krb5

[michael-doubez]

• Changes comply with the maintainer guide.
• SHA512s are updated for each updated download.
• The "supports" clause reflects platforms that may be fixed by this new version.
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[michael-doubez]

@microsoft-github-policy-service agree

[michael-doubez]

LGTM

[michael-doubez]

@jimwang118 Can you please review the PR ?

[jimwang118]

All feature test passed with x64-windows triplet.

[michael-doubez]

@dg0yt krb5 transitive dependency added (thx for pointing that out)

[michael-doubez]

However, one may ask if these features should be default features at all, given vcpkg maintainers' today's reservation. Unless this is the only way to have reasonable security.

I respected the original package intent which was to include the feature by default.
I could have removed the gssapi default but IMHO it is more consistent to either include krb5 by default or not.

krb5 allows using smb with LDAP so it is a sensible default.
It is also smb2's default.

(In addition, I wonder if this could be generalized into a single "kerberos" feature, with platform-specific dependencies and configuration.)

Well, you are right. I suspect that gssapi is in fact part of krb5 but I don't have an ios env to test that so I prefered a /safe/ choice.

[michael-doubez]

@dg0yt hello. Good for you ?

[dg0yt]

@dg0yt hello. Good for you ?

I still assume thatt a single "kerberos" feature would be more appropriate. But I don't want to push the idea. The PR has info:reviewed, and it is not broken.

[michael-doubez]

I ll make the change to have only one feature.
Digging into libsmb2 library, it makes sense.

[michael-doubez]

@dg0yt Here it is. Thank you for your feedback

[JavierMatosD]

Please address the default features comment

[michael-doubez]

Please address the default features comment

@JavierMatosD done as suggested.

Although it means that on Linux people must be aware that feature must be activated if they want krb5 (LDAP ....) support.

Too bad there isn't an "exclude" feature or something like vcpkg install libsmb2[-krb5] because some features (like krb5 here) really make sense: they increase the range of supported protocol without modifying the interface.

[dg0yt]

I wonder if default features should really be stuck with outdated security capabilities.

[michael-doubez]

@JavierMatosD Hello. Could you please review the PR ?

[dg0yt]

@michael-doubez You must mark as ready for review.