Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exprtk] Add version 0.0.3 2024-01-01 #43036

Conversation

ArashPartow
Copy link
Contributor

@ArashPartow ArashPartow commented Dec 31, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

Note: This PR needs to be merged after the PR #42996 has been merged.

Closes the following PRs: #42173, #40270, #33571, #30058, #29955, #29801, #29775, #29665, #38756


@PhoebeHui / @jimwang118 / @JonLiu1993 / @LilyWangLL

@dg0yt
Copy link
Contributor

dg0yt commented Jan 1, 2025

Not resolved: Use lower-case SHA512 and git ref SHA, #42996 (comment).

@dg0yt
Copy link
Contributor

dg0yt commented Jan 1, 2025

Not resolved: Use copyright from upstream repo.

@ArashPartow
Copy link
Contributor Author

@dg0yt It seems you're having troubles so early on in the new year. Hope things work out for you.

@Mengna-Li Mengna-Li added the category:port-update The issue is with a library, which is requesting update new revision label Jan 2, 2025
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms
Copy link
Member

vicroms commented Feb 1, 2025

@ArashPartow

The review comments made by @dg0yt are made in good faith. dg0yt is a longtime contributor to vcpkg and cares about the quality of the ports in the registry.

Regarding specific items:

Versioning

Currently, the exprtk port uses version-date and pins specific Git commits, both #42996 and #43036 maintain the status quo. The version-date scheme is intended for projects that don't intend to publish versioned releases and prefer following a live-at-head approach.

The comments made by @dg0yt and @JavierMatosD suggest changing the scheme to version and updating REF to use the published version tags. Those comments were made in line with our maintainer guideline of preferring upstream's versioning schema. Also, given that Conan and Spack have the exprtk library under versions 0.0.2 and 0.0.3, using them provides familiarity to users.

Copyright

PR #42996 for version 0.0.2 contains a checked in copy of the MIT License text. The maintainer guidelines state that if the license is not available in file form in the source code, then the port should instruct users on how to find the license themselves. The approach in #43036 of using a header file is an acceptable compromise.

SHA512 casing

We recently had a regression with regards to uppercase SHA512s contained in the vcpkg-tool.json file that broke some user scenarios, and while ports were not affected, we would prefer avoiding an issue with custom tooling built on top of vcpkg by keeping a consistent casing for all SHA512. We have updated our maintainer guideline to reflect this requirement.

@vicroms
Copy link
Member

vicroms commented Feb 7, 2025

Thanks for the PR, I merged #43193 since it conforms to the maintainer guidelines.

@vicroms vicroms closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants