Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][libmem] Remove embedded llvm and use port dependency instead #43311

Merged

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Jan 16, 2025

Port libmem failed due to embedded llvm conflicted with port llvm https://dev.azure.com/vcpkg/public/_build/results?buildId=111477&view=logs&j=7922e5c4-0103-5f8f-ad17-45ce9bb98e80&t=8ceef4ed-9be5-594f-e707-4e1dd58a3d21&l=60196

Update libmem to remove embedded lib llvm and use llvm port instead.

Test

The port usage tests pass with the following triplets:

  • x64-linux
  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 16, 2025
@WangWeiLin-MV WangWeiLin-MV changed the title [vcpkg baseline][libmem] Remove embedded lib llvm [vcpkg baseline][libmem] Remove embedded llvm and use port dependency instead Jan 16, 2025
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/libmem/remove-vendored-lib-llvm branch 10 times, most recently from 88556f4 to 8128f78 Compare January 21, 2025 10:13
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/libmem/remove-vendored-lib-llvm branch from 8128f78 to 309fe7d Compare January 22, 2025 03:58
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review January 23, 2025 02:22
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 23, 2025
@vicroms vicroms merged commit b588ddc into microsoft:master Jan 23, 2025
17 checks passed
@WangWeiLin-MV WangWeiLin-MV deleted the ports/libmem/remove-vendored-lib-llvm branch January 24, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants