Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[curl] Add rtmp feature to curl #43403

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[curl] Add rtmp feature to curl #43403

merged 1 commit into from
Jan 23, 2025

Conversation

talregev
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@talregev
Copy link
Contributor Author

talregev commented Jan 22, 2025 •
edited
Loading

Cleaner version of adding rtmp feature to curl without change rtmp port.

@talregev talregev marked this pull request as draft January 22, 2025 12:02
@talregev
Add rtmp feature to curl
3184c37 
Signed-off-by: Tal Regev <tal.regev@gmail.com>
@talregev talregev marked this pull request as ready for review January 22, 2025 12:52
WangWeiLin-MV
WangWeiLin-MV approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port feature [rtmp] installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Jan 23, 2025
@vicroms vicroms merged commit 1516921 into microsoft:master Jan 23, 2025
17 checks passed
@talregev talregev deleted the TalR/curl_rtmp_ci branch January 23, 2025 08:46
@dg0yt
Copy link
Contributor

dg0yt commented Jan 25, 2025 •
edited
Loading

The new feature breaks downstream ports not only on Windows, cf.
https://dev.azure.com/vcpkg/public/_build/results?buildId=111812&view=artifacts&pathAsName=false&type=publishedArtifacts

The port was careful maintained to not require pkg-config for cmake usage. And the problem was known from past attempts. I assume it was deliberately not added to vcpkg-ci-curl to pretend mergable state. But this is not a mature addition.

@dg0yt dg0yt mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talregev @dg0yt @WangWeiLin-MV @vicroms