[libarchive] fix build with VS2017 #586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libarchive uses
check_function_exists
module for feature checks. This macro is completly broken when it comes to compiler built-ins and inline functions (see here and here). As in VS2017wcslen
is also a built-in, libarchive fails to detect it and defines its own version - which ends with "built-in function redefinition" error.This PR provides a patch that skips all problematic checks.