-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow redirection of the scripts folder. #6552
Conversation
It's not clear to me why this feature is necessary. The scripts folder is a core part of vcpkg while the downloads folder is more of a tmp directory. What is the value added for you to be able to redirect the scripts folder? |
It's a missing part for my build scenarios, a single instance of vcpkg managing distributed port directories. |
In #114 you mention that you want a single instance of vcpkg managing many different port directories. From my perspective the scripts folder is a core part of vcpkg. Is the idea just that the vcpkg binary wouldn't have to live in the same directory as the scripts folder? |
Yes, although the dependencies of vcpkg are very low in terms of data sizes, they exist. As you named, the script folder is such a dependency. My workaround is that the script folder is available (through a link or a copy) in a changed vcpkg environment (--vcpkg-root). And this PR would integrate it into vcpkg with no downsides to the average vcpkg user. |
/azp run |
Neither am I. Unfortunately, there hasn't been any alignment on this topic, see #4883. |
…ure-scripts-folder
…ure-scripts-folder
…ure-scripts-folder
To make it more generic, we could also take the .vcpkg-root file to overwrite the folder paths. If nothing is written to the file, it should take the standard paths, otherwise use the overwritten paths from the file. |
Hi @martin-s I made a change to use the |
@martin-s |
* Allow redirection of the scripts folder with an environment variable. * - Updated feature from environment variable to argument. * Fix crash when no scripts override is given and use --scripts-root=<PATH> format * Update help messages to use --scripts-root=<PATH> format
Like in #4883, make scripts folder more flexible.