Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ninja] new port ninja #6825

Closed
wants to merge 2 commits into from
Closed

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Jun 8, 2019

If possible: Could vcpkg internal ninja be replaced with this one or detect that this one was installed and use it instead? (hmm on windows it got pickuped automatically but not on linux. strange) screw that must have done something so that it automatically used it.

@Neumann-A
Copy link
Contributor Author

UWP Error:
LINK : fatal error LNK1104: cannot open file 'libcpmt.lib'

Does somebody know how to solve that one on UWP platforms?

@Neumann-A
Copy link
Contributor Author

@ras0219-msft according to PR 1098 you are probably interested in this one

@cbezault
Copy link
Contributor

So the only thing that failed was UWP. I'm sort of okay with that as people aren't really compiling things on UWP, just compiling things for UWP.

@cbezault
Copy link
Contributor

For now I think we shouldn't have vcpkg auto-detect this is installed and just use it. I'd rather not deal with the flood of issues that will probably result, we want deterministic and consistent builds. However, if a port absolutely needs a newer/different version of ninja than what we ship we should make sure it's easy to switch to ninja built by this port.

@Neumann-A
Copy link
Contributor Author

Then there is nothing more to do for this PR and it could be merged.

@cbezault
Copy link
Contributor

We're considering taking #1098 over this port and using the precompiled ninja binaries from kitware that work with Fortran instead of the ones we currently download.

@Neumann-A
Copy link
Contributor Author

@cbezault Please do as you like as long as it does not take another two years to get it into VCPKG master ;)
I just wanted to offer an alternative for faster Fortran integration.

@cbezault
Copy link
Contributor

Yeah if it looks like it's going to take a significant amount of time to move forward on the fortran PR we might take this one. We just feel that it's not appropriate to have tools as ports and have been discussing maybe adding a new port category for them.

@Neumann-A
Copy link
Contributor Author

closing in favor of #6860

@Neumann-A Neumann-A closed this Jun 11, 2019
@Neumann-A Neumann-A deleted the port_ninja branch September 18, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants