Use sha512 instead of md5 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Ninetainedo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
…-SHA512-instead-of-MD5
Updated doctest Updated mpir
|
Every portfile currently available on master is updated to use SHA512 instead of MD5. |
Telokis
commented
Sep 22, 2016
| cmake_parse_arguments(vcpkg_download_distfile "" "${oneValueArgs}" "" ${ARGN}) | ||
|
|
||
| if(EXISTS ${DOWNLOADS}/${vcpkg_download_distfile_FILENAME}) | ||
| message(STATUS "Using cached ${DOWNLOADS}/${vcpkg_download_distfile_FILENAME}") | ||
| file(MD5 ${DOWNLOADS}/${vcpkg_download_distfile_FILENAME} FILE_HASH) | ||
| if(NOT FILE_HASH MATCHES ${vcpkg_download_distfile_MD5}) |
There was a problem hiding this comment.
I updated this because it failed when vcpkg_download_distfile_MD5 was empty.
| message(FATAL_ERROR | ||
| "File does not have expected hash: ${DOWNLOADS}/${vcpkg_download_distfile_FILENAME}\n" | ||
| " ${FILE_HASH} <> ${vcpkg_download_distfile_MD5}\n" | ||
| " '${FILE_HASH}' <> '${vcpkg_download_distfile_SHA512}'\n" |
There was a problem hiding this comment.
Those quotes allow the user to see empty strings in an easier way.
|
Looks great! Thanks! |
JoergAtGithub
added a commit
to JoergAtGithub/vcpkg
that referenced
this pull request
Aug 12, 2023
DjInterop 0.19.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #61 for every library that was pushed at the moment of the fork.