Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[imgui] Add feature internal to add imgui_internal.h #9125

Closed
wants to merge 2 commits into from
Closed

[imgui] Add feature internal to add imgui_internal.h #9125

wants to merge 2 commits into from

Conversation

AlvinZhangH
Copy link
Contributor

Related issue: #6665.

  1. Add feature internal to use the imgui_internal.h header.
  2. Feature example of this port triplet x86-windows install failed on master branch, and same on my branch.

@AlvinZhangH AlvinZhangH added the info:internal This PR or Issue was filed by the vcpkg team. label Nov 28, 2019
JackBoosY
JackBoosY suggested changes Nov 28, 2019
View reviewed changes
ports/imgui/portfile.cmake Outdated Show resolved Hide resolved
JackBoosY
JackBoosY reviewed Nov 29, 2019
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to discuss whether we should merge this PR.

Related: #8788 #9103.

@AlvinZhangH AlvinZhangH marked this pull request as ready for review January 6, 2020 09:24
@JackBoosY
Copy link
Contributor

/azp run

@idcrook idcrook mentioned this pull request Feb 29, 2020
Merged
@JackBoosY
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@JackBoosY JackBoosY closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY requested changes

@grdowns grdowns Awaiting requested review from grdowns

Assignees

@vicroms vicroms

@JackBoosY JackBoosY

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvinZhangH @JackBoosY @vicroms