[oatpp] Add new port #9402
[oatpp] Add new port #9402
Conversation
…etls3.0 dependency.
|
/azp run |
ports/oatpp/portfile.cmake
Outdated
| set(OATPP_VERSION "0.19.11") | ||
|
|
||
| # go to extraordinary measures to find pkg-config on windows and set the PKG_CONFIG environment variable. | ||
| function(verify_pkg_config SUBMODULE_NAME) |
There was a problem hiding this comment.
vcpkg does not depend on using pkgconfig, please implement this code in other ways (e.g. find_program / find_package / find_library).
There was a problem hiding this comment.
Unfortunately, I'm not an Oat++ developer (just a user) - it may take me a while to figure out how to make patches for the cmake files to get rid of the pkgconfig dependency. If I get a version that works for both vcpkg and the other Oat++ targets, I'll certainly do a pull request for Oat++ to hopefully get rid of Oat++'s dependency on pkgconfig. In the mean time, I've been building Oat++ vcpkg with pkgconfig on Windows and Linux with enough success to be useful - that is, I haven't run into any debug vs release ABI issues (because I defaulted to pkgconfig using release builds).
There was a problem hiding this comment.
Added a patch that detects if compiling in vcpkg and sets the PKG_CURL... variables appropriately for the rest of the build.
ports/oatpp/portfile.cmake
Outdated
| set(OATPP_VERSION "0.19.11") | ||
|
|
||
| vcpkg_check_linkage(ONLY_STATIC_LIBRARY) | ||
| # For when OATPP dynamic linkage builds: |
There was a problem hiding this comment.
If we don't need this code, please delete these commented codes.
There was a problem hiding this comment.
The OATPP_VERSION variable is required.
Oat++ doesn't build with dynamic linkage - I've started looking into the changes necessary and, while I'm no expert on C++ classes in DLLs and shared libraries, I think the changes would be pretty extensive.
There was a problem hiding this comment.
My question is OATPP_BUILD_SHARED_LIBRARIES_OPTION is used in vcpkg_configure_cmake, but it is commented out here.
|
/azp run |
|
Any progress? |
ports/oatpp/portfile.cmake
Outdated
| set(OATPP_VERSION "0.19.11") | ||
|
|
||
| vcpkg_check_linkage(ONLY_STATIC_LIBRARY) | ||
| # For when OATPP dynamic linkage builds: |
There was a problem hiding this comment.
My question is OATPP_BUILD_SHARED_LIBRARIES_OPTION is used in vcpkg_configure_cmake, but it is commented out here.
|
LGTM, thanks for this PR! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Alright, this looks good to me. thanks @mheyman! :D |
Oat++ is a "Modern Web Framework for C++. High performance, simple API, cross-platform, zero-dependency."
I managed to get the core Oat++ and most of the submodules to compile on Windows and Linux - untested on Mac. Oat++ windows support is recent and not available on the libressl submodule (requires libressl3.0 and vcpkg has 2.9.1-2) - the mbedtls submodule covers what I need so it isn't a show-stopper.
Some submodules require pkg-config to be available for building. Vcpkg doesn't seem to have support for pkg-config. Because of this, I had to go through semi-extraordinary measures to detect and use pkg-config and feel lucky that pkg-config to have found a way without resorting to patching Oat++'s CMakeLists.txt files. I did include a message about how to get pkg-config when you don't have it.
(Also, I think PR should have been a continuation of #9244 which I accidentally closed).