You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been working on converting the Roslyn LSP server to STJ in dotnet/roslyn#73207
When validating the changes in VS, I hit a huge number of exception count regressions (thousands in some scenarios), see this internal link. These regressions were not reproducible in my changes locally, nor in the build from the VS insertion, until I either
set the env var StreamJsonRpc_TestWithEventSource
or ran VS under perfview using the streamjsonrpc ETW provider (F0CFFE53-BCC5-53F5-8873-995568808A3B)
The exception stacks in the RPS run pretty much all look like the following:
It appears as though we're hitting this throw in TryGetArgumentByNameOrIndex -
thrownewJsonException("Unexpected value kind for arguments: "+(this.JsonArguments?.ValueKind.ToString()??"null"));
because the JsonRpcEventSource is calling to get a string representation of the message with name: null and where JsonArguments is JsonValueKind.Object -
…em.Text.Json` formatter
This also adjusts how we test with ETW events turned on so that issues like this will be caught rather than swallowed.
Fixesmicrosoft#1038
I've been working on converting the Roslyn LSP server to STJ in dotnet/roslyn#73207
When validating the changes in VS, I hit a huge number of exception count regressions (thousands in some scenarios), see this internal link. These regressions were not reproducible in my changes locally, nor in the build from the VS insertion, until I either
StreamJsonRpc_TestWithEventSource
The exception stacks in the RPS run pretty much all look like the following:
It appears as though we're hitting this throw in
TryGetArgumentByNameOrIndex
-vs-streamjsonrpc/src/StreamJsonRpc/SystemTextJsonFormatter.cs
Line 532 in f6a3b48
because the JsonRpcEventSource is calling to get a string representation of the message with
name: null
and whereJsonArguments
isJsonValueKind.Object
-vs-streamjsonrpc/src/StreamJsonRpc/JsonRpcEventSource.cs
Line 297 in f6a3b48
The text was updated successfully, but these errors were encountered: