Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic generated proxies should expose disconnect event #295

Closed
AArnott opened this issue Jun 21, 2019 · 0 comments · Fixed by #300
Closed

Dynamic generated proxies should expose disconnect event #295

AArnott opened this issue Jun 21, 2019 · 0 comments · Fixed by #300
Assignees
Milestone

Comments

@AArnott
Copy link
Member

AArnott commented Jun 21, 2019

The dynamically generated proxies that derive from IDisposable should also implement an interface that exposes an event that communicates disconnection. Otherwise there's no way for owners of the client proxy instance to know that it's invalid till they try to use it again.

@AArnott AArnott added this to the v2.1 milestone Jun 21, 2019
@AArnott AArnott self-assigned this Jun 22, 2019
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Jun 22, 2019
… itself has

Fixes microsoft#298 by ensuring that *all* dynamic client proxies implement IDisposable
Fixes microsoft#295 by implementing a new IJsonRpcClientProxy interface in each proxy that provides access to the JsonRpc object.
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Jun 22, 2019
… itself has

Fixes microsoft#298 by ensuring that *all* dynamic client proxies implement IDisposable
Fixes microsoft#295 by implementing a new IJsonRpcClientProxy interface in each proxy that provides access to the JsonRpc object.
AArnott added a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant