Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI delay caused by JsonRpc.Dispose() #396

Closed
AArnott opened this issue Dec 5, 2019 · 0 comments
Closed

UI delay caused by JsonRpc.Dispose() #396

AArnott opened this issue Dec 5, 2019 · 0 comments
Assignees
Milestone

Comments

@AArnott
Copy link
Member

AArnott commented Dec 5, 2019

This bug is unique to v2.2. It was introduced in #364 in v2.2 and does not appear in v2.3 because a more complete fix was made there that kept things asynchronous throughout.

JsonRpc.Dispose() calls MessageHandlerBase.Dispose() which blocks the calling thread while waiting for reading/writing to complete. In Visual Studio this is often the UI thread or may be many threadpool threads leading to UI delays for threadpool exhaustion reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant