Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipeMessageHandler.Dispose should not Complete reader/writer directly #413

Closed
AArnott opened this issue Feb 7, 2020 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@AArnott
Copy link
Member

AArnott commented Feb 7, 2020

We are supposed to Complete the reader/writer only after those operations are known to be completely done. Otherwise we risk memory corruption.

this.Reader?.Complete();
this.Writer?.Complete();
base.Dispose(disposing);

@AArnott AArnott added the bug label Feb 7, 2020
@AArnott AArnott added this to the v2.3 milestone Feb 7, 2020
@AArnott AArnott self-assigned this Feb 7, 2020
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Feb 7, 2020
This is a follow-up to microsoft#350 which was evidently incompletely fixed.

Fixes microsoft#413
@AArnott
Copy link
Member Author

AArnott commented Feb 7, 2020

This should have been addressed as part of the fix for #350 but was overlooked.

AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Feb 7, 2020
This is a follow-up to microsoft#350 which was evidently incompletely fixed.

Fixes microsoft#413
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Feb 7, 2020
This is a follow-up to microsoft#350 which was evidently incompletely fixed.

Fixes microsoft#413
@AArnott AArnott closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant