Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-supplied MessagePackSerializerOptions no longer honored at full fidelity #508

Closed
AArnott opened this issue Jul 26, 2020 · 0 comments · Fixed by #509
Closed

User-supplied MessagePackSerializerOptions no longer honored at full fidelity #508

AArnott opened this issue Jul 26, 2020 · 0 comments · Fixed by #509
Assignees
@AArnott
Labels
bug
Milestone
v2.6

Comments

@AArnott
Copy link
Member

AArnott commented Jul 26, 2020

This recent change broke the .Clone() path of the user-supplied MessagePackSerializerOptions by creating our own type and instance. This breaks users who were doing essentially the same thing I was trying to do with that recent change: use the Options to store extra data.
But two can't play that game at once. So we need to come up with a new strategy to pass data to ourselves.

This is a regression introduced in v2.6.34.31951 (#505).
@AArnott AArnott added the bug label Jul 26, 2020
@AArnott AArnott added this to the v2.6 milestone Jul 26, 2020
@AArnott AArnott self-assigned this Jul 26, 2020
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Jul 26, 2020
@AArnott
Add test to verify that custom options for user data make it to the f…
cbf9e72 
…ormatters

It fails, demonstrating bug microsoft#508.
AArnott added a commit to AArnott/vs-streamjsonrpc that referenced this issue Jul 26, 2020
@AArnott
Move our private data from the options object to the resolver
88757a9 
Fixes microsoft#508
@AArnott AArnott mentioned this issue Jul 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
bug
Projects
None yet
Milestone
v2.6
Development

Successfully merging a pull request may close this issue.

Preserve user-supplied MessagePackSerializerOptions AArnott/vs-streamjsonrpc
1 participant
@AArnott