Add support for TEventArgs without type constraints #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonstrates a repro for microsoft#284
It no longer has to derive from EventArgs, but it must still be a reference type. Value types are not yet supported.
jepetty
approved these changes
May 22, 2019
AArnott
added a commit
to AArnott/vs-streamjsonrpc
that referenced
this pull request
Jun 20, 2019
When the delegate's generic type argument is not used directly as the 2nd parameter type in the event handler delegate, a NotSupportedException was thrown starting with pull request microsoft#285. Fixes microsoft#292
AArnott
pushed a commit
that referenced
this pull request
Oct 30, 2024
Bumps [dotnet-coverage](https://github.com/microsoft/codecoverage) from 17.11.5 to 17.12.2. - [Commits](https://github.com/microsoft/codecoverage/commits) --- updated-dependencies: - dependency-name: dotnet-coverage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for proxy generated clients with event handlers that take args that do not derive from
EventArgs.History lesson: From .NET 2.0 to 4.0, the
EventHandler<T>delegate type had a type constraint ofT : EventArgs, meaning that the second parameter that the event handler takes must derive from `EventArgs. In .NET 4.5, this type constraint was dropped. Apparently they consider this a non-breaking change. But when dealing with code gen and reflection, all bets are off. :)Not realizing this, my event wiring code assumed that deriving from
EventArgswas a guarantee. As a result, when a user defines an event typed asEventHandler<T>whereTdoes not derive fromEventArgs, we would fail.This PR fixes it. Supporting
T : classwas as easy as changingEventArgstoobjectin my event handler. But to supportT : structrequired that I bring in a generic method.Fixes #284