-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed exception handling in TransmitAsync #321
Fixed exception handling in TransmitAsync #321
Conversation
Codecov Report
@@ Coverage Diff @@
## v2.1 #321 +/- ##
==========================================
+ Coverage 89.42% 89.64% +0.21%
==========================================
Files 31 31
Lines 1939 1951 +12
Branches 366 369 +3
==========================================
+ Hits 1734 1749 +15
+ Misses 157 156 -1
+ Partials 48 46 -2
Continue to review full report at Codecov.
|
@milopezc, When I asked for you to rebase your changes to the v2.1 branch, it didn't require that you close your PR and open a new one. You can edit the target branch on an existing PR. You can fix this, without closing this PR, by following these steps on your machine:
The commit ID that appears in that command line is your first commit related to this change. You're telling git to move your topic branch (last argument) to v2.1 (first argument), moving all commits up to and excluding the commit named. By stating your commit ID with That will take care of the rebasing. The next thing I would recommend is that you squash your commits since there are quite a few little fix-up commits. You can do that with these commands:
|
34d30d0
to
7c2b07f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, once you get the build to pass.
dabffee
to
73f0c5d
Compare
Revert "Merge pull request #319 from AArnott/betterTestingLibTemplate"
Fixed exception handling in TransmitAsync.