Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-generic client proxy generator method #324

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Aug 21, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #324 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #324     +/-   ##
=========================================
+ Coverage   89.65%   89.86%   +0.2%     
=========================================
  Files          31       31             
  Lines        1923     1943     +20     
  Branches      361      368      +7     
=========================================
+ Hits         1724     1746     +22     
  Misses        151      151             
+ Partials       48       46      -2
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpc.cs 93.43% <100%> (+0.32%) ⬆️
src/StreamJsonRpc/WebSocketMessageHandler.cs 88.46% <0%> (-11.54%) ⬇️
src/StreamJsonRpc/ProxyGeneration.cs 98.28% <0%> (+0.34%) ⬆️
src/StreamJsonRpc/MessageHandlerBase.cs 97.61% <0%> (+2.38%) ⬆️
...treamJsonRpc/Exceptions/ConnectionLostException.cs 75% <0%> (+25%) ⬆️
src/StreamJsonRpc/Exceptions/RemoteRpcException.cs 66.66% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d8a44...e2b0c08. Read the comment docs.

@AArnott AArnott requested review from ikeras and milopezc August 21, 2019 17:29
@AArnott AArnott merged commit dc19c8b into microsoft:master Aug 21, 2019
@AArnott AArnott deleted the AttachNonGeneric branch August 21, 2019 19:41
AArnott added a commit that referenced this pull request Jan 14, 2025
Do not publish artifacts on cancelled GitHub workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants