-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nullable ref types #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only part way through but found some comments.
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
==========================================
- Coverage 87.26% 86.76% -0.51%
==========================================
Files 37 38 +1
Lines 2490 2524 +34
Branches 493 506 +13
==========================================
+ Hits 2173 2190 +17
- Misses 232 243 +11
- Partials 85 91 +6
Continue to review full report at Codecov.
|
233fc95
to
49bf01a
Compare
This enables the C# 8 feature called "nullable reference types" that helps us internally as well as our users to avoid
NullReferenceException
and otherwise understand where we may accept or return null values in our API.