Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable ref types #357

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Enable nullable ref types #357

merged 1 commit into from
Nov 5, 2019

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Nov 4, 2019

This enables the C# 8 feature called "nullable reference types" that helps us internally as well as our users to avoid NullReferenceException and otherwise understand where we may accept or return null values in our API.

@AArnott AArnott added this to the v2.3 milestone Nov 4, 2019
@AArnott AArnott requested review from sharwell and milopezc November 4, 2019 17:05
@AArnott AArnott self-assigned this Nov 4, 2019
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only part way through but found some comments.

src/StreamJsonRpc.Tests/FullDuplexStream.cs Show resolved Hide resolved
src/StreamJsonRpc.Tests/JsonRpcClient20InteropTests.cs Outdated Show resolved Hide resolved
src/StreamJsonRpc.Tests/JsonRpcCustomRequestIdTests.cs Outdated Show resolved Hide resolved
src/StreamJsonRpc.Tests/MessagePackFormatter.cs Outdated Show resolved Hide resolved
src/StreamJsonRpc.Tests/PerfTests.cs Show resolved Hide resolved
src/shipping.ruleset Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #357 into master will decrease coverage by 0.5%.
The diff coverage is 79.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   87.26%   86.76%   -0.51%     
==========================================
  Files          37       38       +1     
  Lines        2490     2524      +34     
  Branches      493      506      +13     
==========================================
+ Hits         2173     2190      +17     
- Misses        232      243      +11     
- Partials       85       91       +6
Impacted Files Coverage Δ
src/StreamJsonRpc/WebSocketMessageHandler.cs 100% <ø> (ø) ⬆️
src/StreamJsonRpc/Exceptions/RemoteRpcException.cs 33.33% <ø> (ø) ⬆️
...treamJsonRpc/Exceptions/ConnectionLostException.cs 50% <ø> (ø) ⬆️
.../StreamJsonRpc/Exceptions/BadRpcHeaderException.cs 33.33% <ø> (ø) ⬆️
src/StreamJsonRpc/JsonRpcEventSource.cs 7.31% <0%> (ø) ⬆️
...sonRpc/Exceptions/RemoteMethodNotFoundException.cs 36.36% <0%> (-20.78%) ⬇️
src/StreamJsonRpc/NullabilityAttributes.cs 0% <0%> (ø)
src/StreamJsonRpc/HeaderDelimitedMessageHandler.cs 82.24% <100%> (+0.21%) ⬆️
src/StreamJsonRpc/Exceptions/LocalRpcException.cs 50% <100%> (ø) ⬆️
...mJsonRpc/EventArgs/JsonRpcDisconnectedEventArgs.cs 88.23% <100%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635efdd...5010894. Read the comment docs.

@AArnott AArnott force-pushed the nrt branch 2 times, most recently from 233fc95 to 49bf01a Compare November 5, 2019 03:56
@AArnott AArnott merged commit d64c14c into microsoft:master Nov 5, 2019
@AArnott AArnott deleted the nrt branch November 5, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants