Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user-supplied JsonConverters when deserializing IProgress<T> report #382

Merged
merged 3 commits into from
Nov 26, 2019

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Nov 26, 2019

Fixes #377 and adds tests (that fail before the fix is applied)

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #382 into master will increase coverage by 0.72%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   90.25%   90.97%   +0.72%     
==========================================
  Files          45       35      -10     
  Lines        3448     2439    -1009     
==========================================
- Hits         3112     2219     -893     
+ Misses        336      220     -116
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonMessageFormatter.cs 93.2% <100%> (+0.36%) ⬆️
src/StreamJsonRpc/Exceptions/LocalRpcException.cs 50% <0%> (-25%) ⬇️
...nRpc/Reflection/MessageFormatterProgressTracker.cs 92.98% <0%> (-2.18%) ⬇️
src/StreamJsonRpc/PipeMessageHandler.cs 89.39% <0%> (-1.97%) ⬇️
src/StreamJsonRpc/SkipClrVisibilityChecks.cs 92.04% <0%> (-1.14%) ⬇️
src/StreamJsonRpc/HeaderDelimitedMessageHandler.cs 86.22% <0%> (-0.17%) ⬇️
src/StreamJsonRpc/ProxyGeneration.cs 99.66% <0%> (-0.04%) ⬇️
...StreamJsonRpc/Reflection/JsonRpcMethodAttribute.cs 100% <0%> (ø) ⬆️
src/StreamJsonRpc/WebSocketMessageHandler.cs 100% <0%> (ø) ⬆️
src/StreamJsonRpc/LengthHeaderMessageHandler.cs 100% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197596a...7a21a4b. Read the comment docs.

Copy link
Contributor

@milopezc milopezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AArnott AArnott merged commit e0c9066 into microsoft:master Nov 26, 2019
@AArnott AArnott deleted the fix377 branch November 26, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom JsonConverter not used for deserialization of items Reported by IProgress instance.
3 participants