Fix hang on deserialization exception #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do this in two ways: 1. If any formatter throws an exception at this fragile point, kill the connection (as we were already doing) but also complete the one Task that we were abandoning before. 1. Fix the MessagePackFormatter to save its exception for a better time so the connection doesn't have to die.
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
=========================================
+ Coverage 90.49% 90.5% +0.01%
=========================================
Files 46 46
Lines 3451 3456 +5
=========================================
+ Hits 3123 3128 +5
Misses 328 328
Continue to review full report at Codecov.
|
milopezc
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of exceptions thrown from result deserializers
I do this in two ways: