Optimize RPC traffic for IAsyncEnumerable<T>
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 90.49% 90.85% +0.36%
==========================================
Files 46 46
Lines 3451 3555 +104
==========================================
+ Hits 3123 3230 +107
+ Misses 328 325 -3
Continue to review full report at Codecov.
|
In particular: * Remove any need to dispose of an enumerable's handle if it was fully enumerated or if any error occurred. * Allow for including values in the initial message that discloses the handle. Also use RFC 2119 key words in protocol spec.
milopezc
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
Also use RFC 2119 key words in protocol spec.
Closes #384