Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MessagePack version #392

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Dec 2, 2019

This requires we adapt to some API changes made in the RC.

@AArnott AArnott added this to the v2.3 milestone Dec 2, 2019
@AArnott AArnott requested review from peterwald and jepetty December 2, 2019 17:52
@AArnott AArnott self-assigned this Dec 2, 2019
@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #392 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #392      +/-   ##
=========================================
+ Coverage   90.49%   90.5%   +0.01%     
=========================================
  Files          46      46              
  Lines        3451    3445       -6     
=========================================
- Hits         3123    3118       -5     
+ Misses        328     327       -1
Impacted Files Coverage Δ
src/StreamJsonRpc/MessagePackFormatter.cs 91.97% <100%> (+0.09%) ⬆️
...pc/Reflection/MessageFormatterDuplexPipeTracker.cs 94.11% <0%> (-1.18%) ⬇️
src/StreamJsonRpc/JsonRpc.cs 93.08% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51bd85...1b49b5f. Read the comment docs.

@AArnott AArnott merged commit f16d000 into microsoft:master Dec 3, 2019
@AArnott AArnott deleted the msgpackUpdate branch December 3, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants