Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document (and test) that obtaining error data is much simpler now #394

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Dec 4, 2019

Fixes #252

@AArnott AArnott added the docs label Dec 4, 2019
@AArnott AArnott added this to the v2.3 milestone Dec 4, 2019
@AArnott AArnott requested review from jepetty and milopezc December 4, 2019 16:39
@AArnott AArnott self-assigned this Dec 4, 2019
@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #394 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   90.97%   90.94%   -0.03%     
==========================================
  Files          47       47              
  Lines        3557     3557              
==========================================
- Hits         3236     3235       -1     
- Misses        321      322       +1
Impacted Files Coverage Δ
...eamJsonRpc/Exceptions/RemoteInvocationException.cs 57.14% <ø> (ø) ⬆️
...pc/Reflection/MessageFormatterDuplexPipeTracker.cs 94.11% <0%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08648a0...9b1fe59. Read the comment docs.

@AArnott AArnott merged commit 3cba133 into microsoft:master Dec 4, 2019
@AArnott AArnott deleted the fix252 branch December 4, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracting exception details on the client is too complicated
3 participants