Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewLineDelimitedMessageHandler #404

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jan 18, 2020

This new handler delimites JSON-RPC messages simply by a new line character.
I've heard of a few such JSON-RPC protocol implementations, which makes sense because people can simply type or paste a JSON-RPC message into a terminal and press enter and it will be processed.

@AArnott AArnott added this to the v2.3 milestone Jan 18, 2020
@AArnott AArnott self-assigned this Jan 18, 2020
@AArnott
Copy link
Member Author

AArnott commented Jan 18, 2020

@Lugghawk Can you try this and confirm it works for you? That would be some great validation to justify completing the PR.

@AArnott AArnott force-pushed the NewlineDelimitedMessageHandler branch from d0955d2 to ae02c98 Compare January 18, 2020 17:27
@codecov-io
Copy link

codecov-io commented Jan 18, 2020

Codecov Report

Merging #404 into v2.3 will increase coverage by 0.06%.
The diff coverage is 86.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v2.3     #404      +/-   ##
==========================================
+ Coverage   90.56%   90.63%   +0.06%     
==========================================
  Files          48       49       +1     
  Lines        3668     3705      +37     
==========================================
+ Hits         3322     3358      +36     
- Misses        346      347       +1
Impacted Files Coverage Δ
src/StreamJsonRpc/Resources.Designer.cs 66.19% <0%> (-0.95%) ⬇️
...rc/StreamJsonRpc/NewLineDelimitedMessageHandler.cs 88.46% <88.46%> (ø)
src/StreamJsonRpc/WebSocketMessageHandler.cs 97.36% <0%> (+10.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e6ca6...ffab450. Read the comment docs.

@Lugghawk
Copy link

Hey, I pulled down the link you had sent me (https://dev.azure.com/azure-public/vside/_build/results?buildId=8136&view=artifacts&type=publishedArtifacts) and installed it, and configured the new handler.

This is now working with my newline-delimited service, and lets me test out my client with nc by pasting in responses/requests.

Thanks!

This new handler delimites JSON-RPC messages simply by a new line character.
I've heard of a few such JSON-RPC protocol implementations, which makes sense because people can simply type or paste a JSON-RPC message into a terminal and press enter and it will be processed.
@AArnott AArnott force-pushed the NewlineDelimitedMessageHandler branch from ae02c98 to ffab450 Compare January 22, 2020 05:49
@AArnott AArnott changed the base branch from master to v2.3 January 22, 2020 14:30
@AArnott AArnott merged commit 370feb1 into microsoft:v2.3 Jan 22, 2020
@AArnott AArnott deleted the NewlineDelimitedMessageHandler branch January 22, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants