Added UseSingleObjectParameterDeserialization option to JsonRpcTargetOptions #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AArnott
requested changes
Apr 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 90.55% 90.56%
=======================================
Files 49 49
Lines 3769 3772 +3
=======================================
+ Hits 3413 3416 +3
Misses 356 356
Continue to review full report at Codecov.
|
|
@daniel-vetter As there are 6 commits for this relatively small change, do you mind if I squash when completing this PR? Or would you like to squash your own commits and do a force push to your branch before I complete it? |
|
@AArnott I squashed everything. You can complete the PR. |
daniel-vetter
deleted the
daniel-vetter/centralized-single-object-parameter-deserialization-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the the
UseSingleObjectParameterDeserializationproperty to the target options. When the property is set to true, theGetRequestMethodToClrMethodMapmethod will add aJsonRpcMethodAttributeto theMethodSignatureAndTarget. I don't know if this is the correct approach becauseGetJsonRpcMethodAttributewill now return a attribute, that did not exist on the original method. But it seems likeAddLocalRpcMethodis also creating fake attributes, so i think it should be ok.resolves #444