Add JsonRpcTargetOptions.DisposeOnDisconnect #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2.4 #450 +/- ##
==========================================
- Coverage 90.54% 90.51% -0.03%
==========================================
Files 49 49
Lines 3732 3752 +20
==========================================
+ Hits 3379 3396 +17
- Misses 353 356 +3
Continue to review full report at Codecov.
|
RyanToth3
approved these changes
Apr 6, 2020
BertanAygun
reviewed
Apr 6, 2020
BertanAygun
reviewed
Apr 6, 2020
src/StreamJsonRpc/JsonRpc.cs
Outdated
| } | ||
| else if (target is IDisposable disposableTarget) | ||
| { | ||
| this.Disconnected += (s, e) => disposableTarget.Dispose(); |
There was a problem hiding this comment.
Since we forget the async tasks, does it change the exception behavior between sync/async dispose cases? I don't remember what happens if you have a Task returning async method but don't await the task.
There was a problem hiding this comment.
They just get dropped on the floor. However in retrospect I guess we could report any exceptions in the JsonRpc.Completion Task.
BertanAygun
approved these changes
Apr 6, 2020
milopezc
approved these changes
Apr 6, 2020
Also invoke target.Dispose on its SynchronizationContext.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #448