Add JsonRpc.DispatchCompletion property #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property returns a Task which completes whenever there are no local RPC methods currently running. This allows shutdown code to not only wait for disconnection, but also for any trailing local RPC methods to finish running, if any. Closes microsoft#466
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 90.37% 90.45% +0.08%
==========================================
Files 50 50
Lines 3812 3823 +11
==========================================
+ Hits 3445 3458 +13
+ Misses 367 365 -2
Continue to review full report at Codecov.
|
|
👍 Looks good from me end. Thanks for the incredibly quick response on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property returns a Task which completes whenever there are no local RPC methods currently running.
This allows shutdown code to not only wait for disconnection, but also for any trailing local RPC methods to finish running, if any.
Closes #466