Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail gracefully if json-rpc 2.0 error or result is missing id #472

Merged
merged 2 commits into from
May 29, 2020

Conversation

NielsUll
Copy link

Fix for issue #471

@msftclas
Copy link

msftclas commented May 29, 2020

CLA assistant check
All CLA requirements met.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #472 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   90.37%   90.67%   +0.29%     
==========================================
  Files          50       50              
  Lines        3823     3828       +5     
==========================================
+ Hits         3455     3471      +16     
+ Misses        368      357      -11     
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonMessageFormatter.cs 95.71% <100.00%> (+2.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bba74b...267751c. Read the comment docs.

Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott
Copy link
Member

AArnott commented May 29, 2020

Looks like we have a problem with our CI/PR build. Let me fix that and get back to you.

@AArnott AArnott self-assigned this May 29, 2020
@AArnott
Copy link
Member

AArnott commented May 29, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AArnott AArnott merged commit 4d9d5c8 into microsoft:master May 29, 2020
@NielsUll NielsUll deleted the dev/nielsull/issue471 branch May 29, 2020 15:11
@AArnott AArnott added this to the v2.5 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If id property is missing in result or error message, code should fail gracefully
4 participants