Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransmissionCompletedSize ETW event #488

Merged
merged 5 commits into from
Jul 14, 2020

Conversation

MokoSan
Copy link
Contributor

@MokoSan MokoSan commented Jul 14, 2020

Updated implementations of IJsonRpcMessageHandler to emit a new event including the size of payload.

These implementations include those of:

  1. HeaderDelimitedMessageHandler.cs
  2. LengthHeaderMessageHandler.cs

@ghost
Copy link

ghost commented Jul 14, 2020

CLA assistant check
All CLA requirements met.

@MokoSan MokoSan closed this Jul 14, 2020
@MokoSan MokoSan reopened this Jul 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #488 into master will decrease coverage by 0.08%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   90.64%   90.55%   -0.09%     
==========================================
  Files          50       50              
  Lines        3838     3844       +6     
==========================================
+ Hits         3479     3481       +2     
- Misses        359      363       +4     
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpcEventSource.cs 6.97% <0.00%> (-0.35%) ⬇️
src/StreamJsonRpc/HeaderDelimitedMessageHandler.cs 85.63% <50.00%> (-0.42%) ⬇️
src/StreamJsonRpc/LengthHeaderMessageHandler.cs 97.22% <50.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae23ed...76ffbf6. Read the comment docs.

@AArnott AArnott changed the title Updated implementations of IJsonRpcMessageHandler to emit a new event including the size of payload Add TransmissionCompletedSize ETW event Jul 14, 2020
@AArnott AArnott merged commit 622bbc8 into microsoft:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants