Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2.5 into master #499

Merged
merged 6 commits into from
Jul 16, 2020
Merged

Merge v2.5 into master #499

merged 6 commits into from
Jul 16, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jul 16, 2020

No description provided.

AArnott and others added 4 commits July 16, 2020 08:47
In case the thrown token isn't exactly the one we passed in, we still want to translate the OCE to an ODE if disposal is in progress.
Fix mis-reported cancellation of message transmission
@AArnott AArnott added this to the v2.6 milestone Jul 16, 2020
@AArnott AArnott self-assigned this Jul 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #499 into master will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   90.64%   91.34%   +0.69%     
==========================================
  Files          50       50              
  Lines        3838     5210    +1372     
==========================================
+ Hits         3479     4759    +1280     
- Misses        359      451      +92     
Impacted Files Coverage Δ
src/StreamJsonRpc/MessageHandlerBase.cs 100.00% <100.00%> (+1.26%) ⬆️
src/StreamJsonRpc/HeaderDelimitedMessageHandler.cs 83.82% <0.00%> (-2.22%) ⬇️
src/StreamJsonRpc/JsonRpcEventSource.cs 6.32% <0.00%> (-0.99%) ⬇️
src/StreamJsonRpc/JsonMessageFormatter.cs 95.09% <0.00%> (-0.62%) ⬇️
src/StreamJsonRpc/ProxyGeneration.cs 99.61% <0.00%> (-0.10%) ⬇️
src/StreamJsonRpc/Protocol/JsonRpcResult.cs 63.63% <0.00%> (ø)
src/StreamJsonRpc/LengthHeaderMessageHandler.cs 100.00% <0.00%> (ø)
src/StreamJsonRpc/Protocol/JsonRpcRequest.cs 88.46% <0.00%> (+1.22%) ⬆️
src/StreamJsonRpc/JsonRpc.cs 94.30% <0.00%> (+1.22%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 813fd29...f0fb950. Read the comment docs.

@AArnott AArnott merged commit f59fa62 into master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants