Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CredScan version #500

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Update CredScan version #500

merged 1 commit into from
Jul 17, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jul 17, 2020

We were getting build warnings from Azure Pipelines about not using the latest version.
Also simplify the names used for both security tasks.

sample run to show this works.

We were getting build warnings from Azure Pipelines about not using the latest version.
Also simplify the names used for both security tasks.
@AArnott AArnott added this to the v2.6 milestone Jul 17, 2020
@AArnott AArnott requested a review from milopezc July 17, 2020 03:38
@AArnott AArnott self-assigned this Jul 17, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #500 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   90.36%   90.42%   +0.06%     
==========================================
  Files          50       50              
  Lines        3892     3876      -16     
==========================================
- Hits         3517     3505      -12     
+ Misses        375      371       -4     
Impacted Files Coverage Δ
src/StreamJsonRpc/MessageHandlerBase.cs 96.34% <0.00%> (-2.44%) ⬇️
src/StreamJsonRpc/WebSocketMessageHandler.cs 97.36% <0.00%> (+10.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59fa62...0e68bd4. Read the comment docs.

@AArnott AArnott merged commit c4e0caf into master Jul 17, 2020
@AArnott AArnott deleted the dev/andarno/secupdates branch July 17, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants